feat: Implement PSR-18 ClientInterface in IClient#59530
Merged
CarlSchwan merged 1 commit intonextcloud:masterfrom Apr 14, 2026
Merged
feat: Implement PSR-18 ClientInterface in IClient#59530CarlSchwan merged 1 commit intonextcloud:masterfrom
CarlSchwan merged 1 commit intonextcloud:masterfrom
Conversation
SMillerDev
requested review from
ArtificialOwl,
artonge,
leftybournes and
salmart-dev
and removed request for
a team
CarlSchwan
approved these changes
Apr 9, 2026
come-nc
approved these changes
Apr 9, 2026
Contributor
|
|
SMillerDev
force-pushed
the
feat/http/psr-18
branch
2 times, most recently
from
7a88bdd to
f5f12f0
Compare
provokateurin
requested changes
Apr 13, 2026
SMillerDev
force-pushed
the
feat/http/psr-18
branch
from
f5f12f0 to
89bced4
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
feat/http/psr-18
branch
from
89bced4 to
769198b
Compare
provokateurin
approved these changes
Apr 14, 2026
Contributor
Author
|
Anyone know how I can get the cypress tests to pass? |
Member
|
Just need to restart them until they pass 🙈 |
8 tasks
Member
|
To the main-maintainers: there are 2 things that should to be checked/confirmed when we expose PSR interfaces:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes sure the
IClientis compliant with PSR-18. This means that any PSR-18 client could be dropped in as a backing client in the future, and it also means that any library using PSR-18 to communicate with a HTTP client can useIClientTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)